From 79cbca5f3f5f0687acf720fb715596ab817f2acc Mon Sep 17 00:00:00 2001 From: Olaf Hering Date: Thu, 6 Oct 2011 12:33:17 +0100 Subject: [PATCH] xenpaging: remove confusing comment from p2m_mem_paging_populate Currently there is no way to avoid the double check of the p2mt because p2m_mem_paging_populate() is called from many places without the p2m_lock held. Upcoming changes will move the function into gfn_to_mfn(), so its interface could be changed and the extra p2m_lock/get_entry can be removed. Signed-off-by: Olaf Hering Acked-by: Tim Deegan Committed-by: Tim Deegan --- xen/arch/x86/mm/p2m.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 49eebb6854..e9266e5322 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -792,8 +792,6 @@ void p2m_mem_paging_populate(struct domain *d, unsigned long gfn) req.type = MEM_EVENT_TYPE_PAGING; /* Fix p2m mapping */ - /* XXX: It seems inefficient to have this here, as it's only needed - * in one case (ept guest accessing paging out page) */ p2m_lock(p2m); p2m->get_entry(p2m, gfn, &p2mt, &a, p2m_query, NULL); if ( p2mt == p2m_ram_paged ) -- 2.30.2